Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much documentation. A few deprecations. #88

Merged
merged 12 commits into from
Oct 15, 2018
Merged

Much documentation. A few deprecations. #88

merged 12 commits into from
Oct 15, 2018

Conversation

boydm
Copy link
Collaborator

@boydm boydm commented Oct 15, 2018

Description

Motivation and Context

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature
    but make things better)

Checklist

  • Check other PRs and make sure that the changes are not done yet.
  • The PR title is no longer than 64 characters.

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #88 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #88      +/-   ##
=========================================
- Coverage   91.45%   91.4%   -0.05%     
=========================================
  Files          80      80              
  Lines        1908    1909       +1     
=========================================
  Hits         1745    1745              
- Misses        163     164       +1
Impacted Files Coverage Δ
lib/scenic/primitive/style/font.ex 100% <ø> (ø) ⬆️
lib/scenic/primitive/path.ex 100% <ø> (ø) ⬆️
lib/scenic/primitive/rectangle.ex 100% <ø> (ø) ⬆️
lib/scenic/primitive/scene_ref.ex 100% <ø> (ø) ⬆️
lib/scenic/primitive/style/font_blur.ex 100% <ø> (ø) ⬆️
lib/scenic/view_port.ex 91.42% <ø> (ø) ⬆️
lib/scenic/primitive/style/scissor.ex 100% <ø> (ø) ⬆️
lib/scenic/primitive/style/font_size.ex 100% <ø> (ø) ⬆️
lib/scenic/primitive/ellipse.ex 100% <ø> (ø) ⬆️
lib/scenic/primitive/style/theme.ex 100% <ø> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39e317...6e5bbab. Read the comment docs.

@boydm boydm merged commit 5ee6195 into master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant