Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventbridge plugin rules and targets incomplete #144

Closed
1 task done
Muthuveerappanv opened this issue Jan 28, 2022 · 4 comments
Closed
1 task done

Eventbridge plugin rules and targets incomplete #144

Muthuveerappanv opened this issue Jan 28, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@Muthuveerappanv
Copy link
Contributor

Have you read the Contributing Guidelines on issues?

Description

When running the eventbridge generator, all events get documented as expected. But the rules and targets, do not get published to the document as expected. Only the last event in the events list is published.

Steps to reproduce

  1. setup the asyncgenerator with eventrbridge plugin
  2. make sure there are more than one event with rules and triggers for each
  3. run npm run generate
  4. observer that not all event documentation will have rules and targets (only one would have it)

Expected behavior

All events with rules and triggers should get documented in the index.md files

Actual behavior

Not all event documentation will have rules and targets (only one would have it)

Your environment

  • EventCatalog version used:
  • Environment name and version (e.g. Chrome 89, Node.js 16.4):
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS)
    Screen Shot 2022-01-28 at 5 18 58 PM
    :
@boyney123
Copy link
Owner

Hi @Muthuveerappanv ,

Thanks for raising the issue.

I'm trying to replicate locally. To help me understand are you using both asyncapi geneartor and eventbridge generator?

What happens if you just use the eventbridge generator out of interest, do your targets work OK?

@boyney123
Copy link
Owner

Ah managed to replicate the issue and see your fix too, will review it, thanks!

boyney123 added a commit that referenced this issue Jan 31, 2022
Co-authored-by: David Boyne <boyneyy123@gmail.com>
@boyney123
Copy link
Owner

Should be fixed in 0.0.5 if you want to give that ago when you can? Let us know how you get on :)

@Muthuveerappanv
Copy link
Contributor Author

works fine in 0.0.5, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants