feat: optional editUrl config #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 407d9e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for eventcatalog-preview ready! 🔨 Explore the source changes: 407d9e0 🔍 Inspect the deploy log: https://app.netlify.com/sites/eventcatalog-preview/deploys/61e6cd8aeb25010008354c8d 😎 Browse the preview: https://deploy-preview-75--eventcatalog-preview.netlify.app |
|
Before screenshot After screenshot |
|
To discuss: |
thim81
commented
Jan 18, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
editUrlis handy for when the event catalog is linked to a public repository.In some cases, the repository cannot be publicly available due to security policies.
This PR provides support for making the
editUrloptional in the eventcatalog.config.jsHave you read the Contributing Guidelines on pull requests?
yes