Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting warnings are shown in console #55

Closed
aaronmcadam opened this issue Jun 28, 2019 · 1 comment
Closed

Linting warnings are shown in console #55

aaronmcadam opened this issue Jun 28, 2019 · 1 comment

Comments

@aaronmcadam
Copy link

First of all, thanks for this, I'm really liking it so far!

What you did:

Booted the client.

What happened:

Google Chrome 2019-06-28 at 13 28 28@2x

Problem description:

This creates just a bit of noise

Suggested solution:

I appreciate that this warnings probably slipped through. Easily done!
@MCRayRay
Copy link

I'll work on cleaning these up.

MCRayRay added a commit to MCRayRay/mockit that referenced this issue Oct 18, 2019
@MCRayRay
Remove 'React' is defined but never used errors
96f74fa 
Fixes boyney123#55
@MCRayRay MCRayRay mentioned this issue Oct 18, 2019
Closed
2 tasks
MCRayRay added a commit to MCRayRay/mockit that referenced this issue Oct 18, 2019
@MCRayRay
Fix 'React' is defined but never used errors
0f79e88 
Fixes boyney123#55
MCRayRay added a commit to MCRayRay/mockit that referenced this issue Oct 18, 2019
@MCRayRay
useScrollReveal: simplify code and remove warning
a9b603b 
Fixes boyney123#55
MCRayRay added a commit to MCRayRay/mockit that referenced this issue Oct 18, 2019
@MCRayRay
Fix 'React' is defined but never used errors
a5ace39 
Fixes boyney123#55
MCRayRay added a commit to MCRayRay/mockit that referenced this issue Oct 19, 2019
@MCRayRay
HeaderInput: fix useEffect missing dependencies
799fe81 
Fixes boyney123#55
MCRayRay added a commit to MCRayRay/mockit that referenced this issue Oct 19, 2019
@MCRayRay
Fix a11y warnings
1111c50 
Fixes boyney123#55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce number of lint errors MCRayRay/mockit
3 participants
@aaronmcadam @MCRayRay @boyney123