Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--exclude-dir cannot handle the slash at the end of dir #250

Closed
c02y opened this issue Apr 9, 2021 · 2 comments
Closed

--exclude-dir cannot handle the slash at the end of dir #250

c02y opened this issue Apr 9, 2021 · 2 comments
Labels
bug Something isn't working
Projects

Comments

@c02y
Copy link

c02y commented Apr 9, 2021

Describe the bug
A clear and concise description of what the bug is.
When I add slash at the end of dir of --exclude-dir, the dir is not excluded.

To Reproduce

# inside scc repo
>> scc --version
scc version 3.0.0
>> scc | rg Total
Total                      178     25942     3002      1729    21211       2327
>> scc --exclude-dir examples/ | rg Total
Total                      178     25942     3002      1729    21211       2327
>> scc --exclude-dir examples | rg Total
Total                       67     19263     1963       668    16632       1476

Expected behavior
A clear and concise description of what you expected to happen.
--exclude-dir should handle that situation that the dir got slash at the end since most of the time I would just tab to complete the dir.

Desktop (please complete the following information):

  • OS: [e.g. macOS, Windows, Linux] Manjaro-Linux
  • Version [e.g. 22] v3.0.0
@boyter boyter added the bug Something isn't working label Apr 11, 2021
@boyter
Copy link
Owner

boyter commented Apr 11, 2021

Confirmed here. One for the next release. Thanks for the report.

@boyter boyter added this to Todo in 3.1.0 Apr 25, 2021
@boyter boyter closed this as completed in 08974a2 Dec 15, 2021
@boyter boyter moved this from Todo to Done in 3.1.0 Dec 15, 2021
@boyter
Copy link
Owner

boyter commented Dec 15, 2021

Resolved in mainline. Sorry about how long it took to get around to this. Pretty crazy year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
3.1.0
Done
Development

No branches or pull requests

2 participants