Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript multiline comment /**/ should be added to vue multi line comment list #253

Closed
foxdd opened this issue Apr 18, 2021 · 3 comments
Closed

JavaScript multiline comment /**/ should be added to vue multi line comment list #253

foxdd opened this issue Apr 18, 2021 · 3 comments
Labels
bug Something isn't working
Projects
3.1.0

Comments

@foxdd
Copy link
Contributor

foxdd commented Apr 18, 2021

Describe the bug
As a vue file includes js language as well as html language, the javascript multiline comment token should be added to vue multiline list. Otherwise the JavaScript multiline comment will not be recognised
@foxdd foxdd changed the title JavaScript multiline comment /**/ should be added to vue multi line comment JavaScript multiline comment /**/ should be added to vue multi line comment list Apr 18, 2021
@boyter boyter added the bug Something isn't working label Apr 25, 2021
@boyter boyter added this to Todo in 3.1.0 Apr 25, 2021
@foxdd
Copy link
Contributor Author

foxdd commented Jul 16, 2021

By the way, single quotation mark also needs to be made as a member of quotes array of javascript language

@boyter
Copy link
Owner

boyter commented Jul 19, 2021

Good point. Ill have a look through this more closely. If you want a fix now though send through a PR and ill merge it.

@boyter boyter closed this as completed in 5be40c8 Dec 14, 2021
@boyter boyter moved this from Todo to Done in 3.1.0 Dec 14, 2021
@boyter
Copy link
Owner

boyter commented Dec 14, 2021

Resolved in master now. A build from there should fix everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
3.1.0
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boyter @foxdd