Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of options matters #41

Closed
nickmchardy opened this issue Oct 22, 2018 · 3 comments
Closed

Order of options matters #41

nickmchardy opened this issue Oct 22, 2018 · 3 comments
Labels
good first issue Good for newcomers question Further information is requested

Comments

@nickmchardy
Copy link

scc -v . works fine
scc . -v does not work (options like -v are ignored)
@nickmchardy
Copy link
Author

PS. in v1.11.0

@boyter
Copy link
Owner

boyter commented Oct 22, 2018

Yeah its an annoying thing about the CLI library I used. Not sure its that big a problem considering tools like ripgrep tokei cloc loc fd all work the same way.

If its easy to drop in Cobra https://github.com/spf13/cobra and it works supporting the above ill consider moving over to that.

@boyter boyter added good first issue Good for newcomers question Further information is requested labels Oct 22, 2018
@boyter
Copy link
Owner

boyter commented Oct 23, 2018

PR 225ac79 should resolve this, however it means the options have changed (breaking change).

Ill have a poke with it and then make a new release.

@boyter boyter closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boyter @nickmchardy