Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gcp auth fixes #1 #2

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Add gcp auth fixes #1 #2

merged 1 commit into from
Aug 16, 2017

Conversation

ofpiyush
Copy link
Contributor

No description provided.

@ofpiyush
Copy link
Contributor Author

Fixes #1

boz added a commit that referenced this pull request Aug 16, 2017
@boz
vendor: gcp auth client
e1dade7 
refs #1 #2
@boz
Copy link
Owner

boz commented Aug 16, 2017

thanks so much @ofpiyush. this works great after vendoring the library with govendor fetch k8s.io/client-go/plugin/pkg/client/auth/gcp. See here

@boz boz merged commit 89132ac into boz:master Aug 16, 2017
@ofpiyush
Copy link
Contributor Author

My bad, I thought the package would come with the base client-go package. Thank you for fixing and merging it in ❤️

@ofpiyush ofpiyush deleted the patch-1 branch August 16, 2017 17:48
@boz boz mentioned this pull request Aug 16, 2017
Closed
@boz boz mentioned this pull request Aug 30, 2017
Closed
@coryodaniel coryodaniel mentioned this pull request Jul 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ofpiyush @boz