Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github workflow for CI, added krew, updated homebrew #83

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

chandanpasunoori
Copy link
Collaborator

@chandanpasunoori chandanpasunoori commented Dec 27, 2022

  • added github workflow
  • added krew publishing conf in goreleaser
  • updated homebrew with more details
  • support for arm64/apple silicon configured is end to end with ci

@boz: to make installation more easy for everybody who is using this awesome pluging, please do follow below steps.

if you are busy you can add me as maintainer to repo, I will update as and when required, in our work place we use this heavily

  1. you need to fork krew-index repo as boz/krew-index
  2. once this is merged, you should create tag like 1.16.0
    • it will update homebrew tap file in boz/homebrew-repo
    • it will update krew manifest file in boz/krew-index
  3. you need to create pull request from boz/krew-index to kubernetes-sigs/krew-index (upstream)

fix #68
fix #67

@chandanpasunoori
Copy link
Collaborator Author

@boz @mnaser can you look into this

@boz boz merged commit e1e6369 into boz:master Jan 4, 2023
@boz
Copy link
Owner

boz commented Jan 4, 2023

thanks so much @chandanpasunoori !

@rajatjindal
Copy link

Hi @chandanpasunoori

thank you for making this contribution.

I am just curious why we need to open PR to kubernetes-sigs/krew-index manually. I was under impression it will work automatically (with goreleaser or krew-release-bot)

Disclaimer: I authored and maintain krew-release-bot.

@chandanpasunoori
Copy link
Collaborator Author

chandanpasunoori commented Jan 6, 2023

@rajatjindal goreleaser will update the repo you own, it will not create pull request automatically, which we need to separately or with another action step to automate

Ref https://goreleaser.com/customization/krew/

I will check about krew-release-bot

@chandanpasunoori
Copy link
Collaborator Author

@rajatjindal fyi: I've WIP update to automate krew-index pull request.

@chandanpasunoori
Copy link
Collaborator Author

@rajatjindal its nice, I will update, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm64 support in krew Become a Krew extension
3 participants