pkp/pkp-lib#2942 fix infinite loop in upgrade if file is missing

bozana · Oct 25, 2017 · 38d5d2b · 38d5d2b
1 parent 18c12ac
commit 38d5d2b
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/classes/install/Upgrade.inc.php b/classes/install/Upgrade.inc.php
@@ -114,6 +114,7 @@ function removeReviewEntries() {
 				} elseif (count($matchedResults)==0) {
 					// No filenames matched. Skip migrating.
 					error_log("WARNING: Unable to find a match for \"$globPattern\" in \"" . $submissionFileManager->getBasePath() . "\". Skipping this file.");
+					$fileResult->MoveNext();
 					continue;
 				}
 				$discoveredFilename = array_shift($matchedResults);
@@ -122,6 +123,7 @@ function removeReviewEntries() {
 					unlink($discoveredFilename);
 				} else {
 					error_log("WARNING: File \"$discoveredFilename\" does not exist.");
+					$fileResult->MoveNext();
 					continue;
 				}
 				$fileResult->MoveNext();