Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send issued certificates to teacher's email too #130 #133

Closed
wants to merge 2 commits into from
Closed

Send issued certificates to teacher's email too #130 #133

wants to merge 2 commits into from

Conversation

lachlan-00
Copy link

I think i've done this correctly, please let me know if i've missed anything. (This is my first moodle plugin edit.)

This pull request should close this bug/request
Send issued certificates to teacher's email too #130

It will:

  • Allow the pdf certificate that is sent to students to be sent to class teachers as well.
  • It has an option to turn it on or off in the plugin settings.
  • It has install and upgrade check in the script
  • strings are separated from the student email strings and will only run when enabled by the plugin.

Please check my code out and make any changes you would like.

I think it might be a good idea to only set $tchsubject and $tchmessage inside the ($this->get_instance()->cert2teacher == 1) section but i only realised this when i'd finished typing...

@rlcharles
Copy link

@bozoh Are you accepting pull requests for this block ?

@bozoh
Copy link
Owner

bozoh commented Nov 11, 2016

The implementation is ok, but incomplete, i think.
That why:

  • Must put cert2teacher as an option in certificate creation/edit form, so it's can be configured per certificate instance, not global for all certificates.
  • settings.php will only define the default value in creation form, and i think the default value should be disabled

@bozoh bozoh closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants