forked from openshift/origin
-
Notifications
You must be signed in to change notification settings - Fork 1
/
authorization.go
233 lines (192 loc) · 7.35 KB
/
authorization.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
package authorization
import (
"errors"
"fmt"
"io"
"k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
utilerrors "k8s.io/apimachinery/pkg/util/errors"
rbacinternalversion "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/rbac/internalversion"
"k8s.io/kubernetes/pkg/kubectl/cmd/templates"
kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
"k8s.io/kubernetes/pkg/kubectl/resource"
authorizationapi "github.com/openshift/origin/pkg/authorization/apis/authorization"
"github.com/openshift/origin/pkg/authorization/registry/util"
"github.com/openshift/origin/pkg/cmd/util/clientcmd"
"github.com/openshift/origin/pkg/oc/admin/migrate"
"github.com/spf13/cobra"
)
var (
internalMigrateAuthorizationLong = templates.LongDesc(`
Check for parity between Openshift authorization objects and Kubernetes RBAC
A controller is used to keep Openshift authorization objects and Kubernetes RBAC in sync.
This command checks for parity between those objects across all namespaces and reports
all objects that are out of sync. These objects require manual intervention to sync
as the controller handles all cases where automatic sync is possible.
The following resource types are checked by this command:
* clusterrole
* role
* clusterrolebinding
* rolebinding
No resources are mutated.`)
errOutOfSync = errors.New("is not in sync with RBAC")
)
type MigrateAuthorizationOptions struct {
migrate.ResourceOptions
rbac rbacinternalversion.RbacInterface
}
func NewCmdMigrateAuthorization(name, fullName string, f *clientcmd.Factory, in io.Reader, out, errout io.Writer) *cobra.Command {
options := &MigrateAuthorizationOptions{
ResourceOptions: migrate.ResourceOptions{
In: in,
Out: out,
ErrOut: errout,
AllNamespaces: true,
Include: []string{
"clusterroles.authorization.openshift.io",
"roles.authorization.openshift.io",
"clusterrolebindings.authorization.openshift.io",
"rolebindings.authorization.openshift.io",
},
},
}
cmd := &cobra.Command{
Use: name,
Short: "Confirm that Origin authorization resources are in sync with their RBAC equivalents",
Long: internalMigrateAuthorizationLong,
Run: func(cmd *cobra.Command, args []string) {
kcmdutil.CheckErr(options.Complete(name, f, cmd, args))
kcmdutil.CheckErr(options.Validate())
kcmdutil.CheckErr(options.Run())
},
Deprecated: fmt.Sprintf("will not work against 3.7 servers"),
}
return cmd
}
func (o *MigrateAuthorizationOptions) Complete(name string, f *clientcmd.Factory, c *cobra.Command, args []string) error {
if len(args) != 0 {
return fmt.Errorf("%s takes no positional arguments", name)
}
if err := o.ResourceOptions.Complete(f, c); err != nil {
return err
}
kclient, err := f.ClientSet()
if err != nil {
return err
}
if err := clientcmd.LegacyPolicyResourceGate(kclient.Discovery()); err != nil {
return err
}
o.rbac = kclient.Rbac()
return nil
}
func (o MigrateAuthorizationOptions) Validate() error {
return o.ResourceOptions.Validate()
}
func (o MigrateAuthorizationOptions) Run() error {
return o.ResourceOptions.Visitor().Visit(func(info *resource.Info) (migrate.Reporter, error) {
return o.checkParity(info.Object)
})
}
// checkParity confirms that Openshift authorization objects are in sync with Kubernetes RBAC
// and returns an error if they are out of sync or if it encounters a conversion error
func (o *MigrateAuthorizationOptions) checkParity(obj runtime.Object) (migrate.Reporter, error) {
var errlist []error
switch t := obj.(type) {
case *authorizationapi.ClusterRole:
errlist = append(errlist, o.checkClusterRole(t)...)
case *authorizationapi.Role:
errlist = append(errlist, o.checkRole(t)...)
case *authorizationapi.ClusterRoleBinding:
errlist = append(errlist, o.checkClusterRoleBinding(t)...)
case *authorizationapi.RoleBinding:
errlist = append(errlist, o.checkRoleBinding(t)...)
default:
return nil, nil // indicate that we ignored the object
}
return migrate.NotChanged, utilerrors.NewAggregate(errlist) // we only perform read operations
}
func (o *MigrateAuthorizationOptions) checkClusterRole(originClusterRole *authorizationapi.ClusterRole) []error {
var errlist []error
// convert the origin role to a rbac role
convertedClusterRole, err := util.ConvertToRBACClusterRole(originClusterRole)
if err != nil {
errlist = append(errlist, err)
}
// try to get the equivalent rbac role from the api
rbacClusterRole, err := o.rbac.ClusterRoles().Get(originClusterRole.Name, v1.GetOptions{})
if err != nil {
errlist = append(errlist, err)
}
// compare the results if there have been no errors so far
if len(errlist) == 0 {
// if they are not equal, something has gone wrong and the two objects are not in sync
if util.PrepareForUpdateClusterRole(convertedClusterRole, rbacClusterRole) {
errlist = append(errlist, errOutOfSync)
}
}
return errlist
}
func (o *MigrateAuthorizationOptions) checkRole(originRole *authorizationapi.Role) []error {
var errlist []error
// convert the origin role to a rbac role
convertedRole, err := util.ConvertToRBACRole(originRole)
if err != nil {
errlist = append(errlist, err)
}
// try to get the equivalent rbac role from the api
rbacRole, err := o.rbac.Roles(originRole.Namespace).Get(originRole.Name, v1.GetOptions{})
if err != nil {
errlist = append(errlist, err)
}
// compare the results if there have been no errors so far
if len(errlist) == 0 {
// if they are not equal, something has gone wrong and the two objects are not in sync
if util.PrepareForUpdateRole(convertedRole, rbacRole) {
errlist = append(errlist, errOutOfSync)
}
}
return errlist
}
func (o *MigrateAuthorizationOptions) checkClusterRoleBinding(originRoleBinding *authorizationapi.ClusterRoleBinding) []error {
var errlist []error
// convert the origin role binding to a rbac role binding
convertedRoleBinding, err := util.ConvertToRBACClusterRoleBinding(originRoleBinding)
if err != nil {
errlist = append(errlist, err)
}
// try to get the equivalent rbac role binding from the api
rbacRoleBinding, err := o.rbac.ClusterRoleBindings().Get(originRoleBinding.Name, v1.GetOptions{})
if err != nil {
errlist = append(errlist, err)
}
// compare the results if there have been no errors so far
if len(errlist) == 0 {
// if they are not equal, something has gone wrong and the two objects are not in sync
if util.PrepareForUpdateClusterRoleBinding(convertedRoleBinding, rbacRoleBinding) {
errlist = append(errlist, errOutOfSync)
}
}
return errlist
}
func (o *MigrateAuthorizationOptions) checkRoleBinding(originRoleBinding *authorizationapi.RoleBinding) []error {
var errlist []error
// convert the origin role binding to a rbac role binding
convertedRoleBinding, err := util.ConvertToRBACRoleBinding(originRoleBinding)
if err != nil {
errlist = append(errlist, err)
}
// try to get the equivalent rbac role binding from the api
rbacRoleBinding, err := o.rbac.RoleBindings(originRoleBinding.Namespace).Get(originRoleBinding.Name, v1.GetOptions{})
if err != nil {
errlist = append(errlist, err)
}
// compare the results if there have been no errors so far
if len(errlist) == 0 {
// if they are not equal, something has gone wrong and the two objects are not in sync
if util.PrepareForUpdateRoleBinding(convertedRoleBinding, rbacRoleBinding) {
errlist = append(errlist, errOutOfSync)
}
}
return errlist
}