Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom in issue in Safari (desktop and mobile) #144

Closed
ghost opened this issue Mar 26, 2020 · 4 comments
Closed

Zoom in issue in Safari (desktop and mobile) #144

ghost opened this issue Mar 26, 2020 · 4 comments
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Mar 26, 2020

Describe the bug
Steps to reproduce:

  1. Open Pigallery2 in safari
  2. Click on picture to zoom in
  3. See the issue

Screenshots
https://www.youtube.com/watch?v=y5782hvQWbc&feature=share

Environment (please complete the following information):

  • OS: MacOS Mojave, iOS
  • Browser: Safari

Used app version:

  • docker latest
@bpatrik bpatrik added the bug label Mar 28, 2020
@bpatrik
Copy link
Owner

bpatrik commented Mar 28, 2020

Hi, thanks for the report.
I started at a new company that has strong restriction on hobby projects. It will take some time until I sort it out, so I cannot give you a date when it will be ready.

Patrik

@ghost
Copy link
Author

ghost commented Apr 2, 2020

@bpatrik no worries, I am just reporting things I am finding. Great work btw, I am very happy with Pigallery2 running on my RPI. Hopefully I can invest some time to learn Angular and fix some of the issues.

@bpatrik
Copy link
Owner

bpatrik commented Apr 19, 2021

I made some updates to the code, that potentially also improves this.

I tested it on a iPad. It does not produce the issues that you have in the video, but zoom still not work.

bpatrik added a commit that referenced this issue Apr 19, 2021
It is needed since angular 9.

Tested on Pixel4, Ipad Air
@bpatrik
Copy link
Owner

bpatrik commented Apr 19, 2021

It turns out since angular 9, hammerjs does not work by default. Fixed that.

@bpatrik bpatrik added this to the v1.9 milestone May 3, 2021
@bpatrik bpatrik closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant