Fix code that resolves the extension directory path #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpatrik
reviewed
Apr 29, 2024
| @@ -10,6 +10,6 @@ try { | |||
| pre.loadSync({preventSaving: true}); | |||
| } catch (e) { /* empty */ | |||
| } | |||
| ExtensionConfigTemplateLoader.Instance.init(path.join(__dirname, '/../../../../', pre.Extensions.folder)); | |||
| ExtensionConfigTemplateLoader.Instance.init(pre.Extensions.folder); | |||
There was a problem hiding this comment.
I'm not sure if that works in all cases. Let me take a look.
There was a problem hiding this comment.
yeah so the docker used absolute path, while my test setup used a relative one.
Your setup fixes it for absolute path (eg the docker build), but breaks it for absolute.
My last commit should fix it for both.
bpatrik
added a commit
that referenced
this pull request
Apr 29, 2024
|
Fixed by a different commit, no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the last fix needed for #847.