Manage teardown with shared_ptr not CountDownLatch #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpcreech
force-pushed
the
feature/shared-ptr
branch
2 times, most recently
from
6c76bd8 to
3ddda40
Compare
It's hard to manage object lifecycle in the C++ side of PyMiniRacer because objects are often referenced in callbacks sent into the Isolate message pump. Before we tried to explicitly manage lifecycle, and used a CountDownLatch to ensure all the async work was done before closing out the Isolate. In this change, we just switch everything to shared_ptr and let the Isolate shut itself down when nothing else refers to it.
bpcreech
force-pushed
the
feature/shared-ptr
branch
from
3ddda40 to
c0efb43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to manage object lifecycle in the C++ side of PyMiniRacer because objects are often referenced in callbacks sent into the Isolate message pump. Before we tried to explicitly manage lifecycle, and used a
CountDownLatchto ensure all the async work was done before closing out the Isolate. In this change, we just switch everything toshared_ptrand let the Isolate shut itself down when nothing else refers to it.