Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox sessionStorage Issues #5

Closed
bpedroza opened this issue Dec 1, 2020 · 10 comments
Closed

Firefox sessionStorage Issues #5

bpedroza opened this issue Dec 1, 2020 · 10 comments

Comments

@bpedroza
Copy link
Owner

bpedroza commented Dec 1, 2020

Issue originates from PR - #4 from @revir

My Findings:
I tested in firefox, and this is not the case. Are you doing something else with your flow? The sessionStorage data is not persisted across tabs, but it is persisted in the same tab. Are you opening a new window to authorize or something?

@revir
Copy link

revir commented Dec 1, 2020

Yes, I followed your guidelines to replace the location history to authorize. I use it in my project: https://github.com/pnlpal/dictionaries, though it's a popup window type, but still it's a window. No new tab or new window. I also suspect it's a bug, my env is Firefox 82.0.2-1 on Manjaro Linux.
I will have more test, and will tell you more what i find. Thank you.

@bpedroza
Copy link
Owner Author

bpedroza commented Dec 1, 2020

Can you please give me a link to the part of your code where this library is being used?

@revir
Copy link

revir commented Dec 1, 2020

https://github.com/pnlpal/dictionaries/blob/master/src/content/music-player.coffee#L41-L72

It's in coffee script, kind of like python.
when click on authorize, the function authorize will be called, so the flow begins.

@revir
Copy link

revir commented Dec 1, 2020

@bpedroza oh no, my bad. I found the problem. I use it in an iframe, then change the location of the top window.

@bpedroza
Copy link
Owner Author

bpedroza commented Dec 1, 2020

Thanks. I'll check it out. Please continue your own testing and let me know what you find.

@bpedroza
Copy link
Owner Author

bpedroza commented Dec 1, 2020

Ah, that makes sense. Can you work around on your end?

@revir
Copy link

revir commented Dec 1, 2020

I guess that's why the sessionStorage is freed. Somehow chrome is not like that.

@revir
Copy link

revir commented Dec 1, 2020

yeah, it's should be my problem. Somehow this modular is not working on Firefox anyway...
Thanks for helping though, I guess this is a interesting way to debug.

@bpedroza
Copy link
Owner Author

bpedroza commented Dec 1, 2020

Sure. If you're having more issues with firefox, please let me know. I want this package to work for all modern browsers, and if sessionStorage is going to continue to be a problem, maybe we can introduce a way to swap storage types.

@bpedroza bpedroza closed this as completed Dec 1, 2020
@revir
Copy link

revir commented Dec 1, 2020

sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants