-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox sessionStorage Issues #5
Comments
Yes, I followed your guidelines to replace the location history to authorize. I use it in my project: https://github.com/pnlpal/dictionaries, though it's a popup window type, but still it's a window. No new tab or new window. I also suspect it's a bug, my env is Firefox 82.0.2-1 on Manjaro Linux. |
Can you please give me a link to the part of your code where this library is being used? |
https://github.com/pnlpal/dictionaries/blob/master/src/content/music-player.coffee#L41-L72 It's in coffee script, kind of like python. |
@bpedroza oh no, my bad. I found the problem. I use it in an iframe, then change the location of the top window. |
Thanks. I'll check it out. Please continue your own testing and let me know what you find. |
Ah, that makes sense. Can you work around on your end? |
I guess that's why the sessionStorage is freed. Somehow chrome is not like that. |
yeah, it's should be my problem. Somehow this modular is not working on Firefox anyway... |
Sure. If you're having more issues with firefox, please let me know. I want this package to work for all modern browsers, and if sessionStorage is going to continue to be a problem, maybe we can introduce a way to swap storage types. |
sure. |
Issue originates from PR - #4 from @revir
My Findings:
I tested in firefox, and this is not the case. Are you doing something else with your flow? The sessionStorage data is not persisted across tabs, but it is persisted in the same tab. Are you opening a new window to authorize or something?
The text was updated successfully, but these errors were encountered: