Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use localStorage instead of sessionStorage to keep state #4

Closed
wants to merge 1 commit into from

Conversation

revir
Copy link

@revir revir commented Dec 1, 2020

Hi, thanks for this useful library. I found that sessionStorage is cleared on Firefox as soon as the current location is changed to the authorizing website. So I use localStorage instead. How do you think?

@bpedroza
Copy link
Owner

bpedroza commented Dec 1, 2020

This PR is not the correct place to discuss the issue. Please continue discussion in an issue I opened - #5

@revir
Copy link
Author

revir commented Dec 1, 2020 via email

@bpedroza
Copy link
Owner

bpedroza commented Dec 1, 2020

Please, use the issue I created to discuss. I am closing this PR until more discussion is had to make a decision.

@bpedroza bpedroza closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants