Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flash: Make onion packets fixed-size #1614

Closed
AndrejMitrovic opened this issue Feb 9, 2021 · 1 comment
Closed

Flash: Make onion packets fixed-size #1614

AndrejMitrovic opened this issue Feb 9, 2021 · 1 comment
Assignees
@AndrejMitrovic
Labels
C. Payment Channel Related to Flash TestNet Story-Points:8 This takes 5 to 7 days to complete type-feature An addition to the system introducing new functionalities
Projects
Sprint #37 (2021-02-23 to 2021-03-08)
Milestone
3. Flash Layer

Comments

@AndrejMitrovic
Copy link
Contributor

In #1529 onion encrypted packets were implemented. However their size varies based on the number of hops.

In LN the onion packet is always of a fixed size. This ensures no node can ever known how many hops the packet has traveled or how many hops it still needs to travel. The hops only know about the previous and next hops. This is an important privacy feature.

For this we should consult these pages:
@AndrejMitrovic AndrejMitrovic self-assigned this Feb 9, 2021
@AndrejMitrovic AndrejMitrovic added Story-Points:8 This takes 5 to 7 days to complete type-feature An addition to the system introducing new functionalities labels Feb 9, 2021
@AndrejMitrovic AndrejMitrovic added this to the 3. Flash Layer milestone Feb 17, 2021
@AndrejMitrovic AndrejMitrovic added the C. Payment Channel Related to Flash TestNet label Feb 17, 2021
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Feb 19, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
240d013 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
@AndrejMitrovic AndrejMitrovic mentioned this issue Feb 19, 2021
Merged
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Feb 19, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
24147d8 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Feb 19, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
00c376e 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Feb 22, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
172da1d 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Feb 22, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
e0e2db1 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
@bpalaggi bpalaggi added this to To do in Sprint #37 (2021-02-23 to 2021-03-08) via automation Feb 23, 2021
@bpalaggi bpalaggi moved this from To do to Review/Testing in Sprint #37 (2021-02-23 to 2021-03-08) Feb 23, 2021
omerfirmak pushed a commit that referenced this issue Feb 23, 2021
@AndrejMitrovic @omerfirmak
Change onion packets to be fixed-size
2896282 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes #1614
@AndrejMitrovic
Copy link
Contributor Author

Resolved in #1673

Sprint #37 (2021-02-23 to 2021-03-08) automation moved this from Review/Testing to Done Feb 23, 2021
AndrejMitrovic added a commit that referenced this issue Feb 24, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
dddb7d6 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes #1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 3, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
fcff468 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 5, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
00a9059 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 8, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
836459c 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 8, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
1730a0a 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 8, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
f48487d 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 8, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
9907a92 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 8, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
d859323 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 8, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
ef6be47 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 9, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
a9a11c4 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 9, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
7087eab 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 9, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
b95de33 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 9, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
c9f4128 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 9, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
cb0b197 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 9, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
30309e4 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Mar 10, 2021
@AndrejMitrovic
Change onion packets to be fixed-size
314da26 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes bosagora#1614
omerfirmak pushed a commit that referenced this issue Mar 10, 2021
@AndrejMitrovic @omerfirmak
Change onion packets to be fixed-size
5474410 
It's an alternative and simpler solution
compared to LN's recursive onion definition.

Fixes #1614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrejMitrovic AndrejMitrovic

Labels
C. Payment Channel Related to Flash TestNet Story-Points:8 This takes 5 to 7 days to complete type-feature An addition to the system introducing new functionalities
Projects
No open projects
Sprint #37 (2021-02-23 to 2021-03-08)
  
Done
Milestone
3. Flash Layer
Development

No branches or pull requests
1 participant
@AndrejMitrovic