Enable printf, cat, system to have more args #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyuee
force-pushed
the
more_args_for_printf
branch
3 times, most recently
from
e240300
to
bb2e5d4
Compare
danobi
requested changes
Jun 30, 2020
suyuee
force-pushed
the
more_args_for_printf
branch
2 times, most recently
from
19fe460
to
13359f8
Compare
danobi
reviewed
Jul 2, 2020
suyuee
force-pushed
the
more_args_for_printf
branch
3 times, most recently
from
b969a31
to
ff83b75
Compare
|
Conflicts Resolved. |
suyuee
force-pushed
the
more_args_for_printf
branch
from
ff83b75
to
4fdcf3f
Compare
|
One more thing: can you put the non-checklist portions of the PR description in the commit message? |
This enables printf, cat and system to have more than 7 arguments. It can be more user-friendly to allow any reasonable number of arguments for these builtin calls which use formatted strings. Resolves bpftrace#1336.
suyuee
force-pushed
the
more_args_for_printf
branch
from
4fdcf3f
to
f2cdf87
Compare
|
Sure. Already done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
printf,catandsystemto have more than 7 arguments. It can be more user-friendly to allow any reasonable number of arguments for these builtin calls which use formatted strings. Resolves #1336.Checklist
docs/reference_guide.mdCHANGELOG.md