-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wildcards for tracepoint categories #1445
Conversation
512a43e
to
0b89d13
Compare
Embedded build failed on a uprobe test (cannot open mount ns), which shouldn't be affected by this PR. Not sure why the error occurred, it passed on my fork's branch build. Also there are clang-format fails in a new test that I copied from an existing one (which contains the same format errors, too). |
Some tests are still somewhat flaky and fail sporadically, rerunning it usually fixes it
We try to incrementally fix the formatting errors. So if you touch code you format it. This way we can keep git blame useful. |
I kicked off another round of embedded tests. Let's see if it passes this time.
+1 |
0b89d13
to
e5cee42
Compare
It is now possible to run e.g. this: bpftrace -e 'tracepoint:kvm*:* { @[probe] = count(); }' Changes were done to wildcard matching: prefix is no longer used (since no probe type uses a fixed prefix), the tracepoint category is made a part of the function pattern. Also, find_wildcard_matches now returns tracepoint matches in the form "category:event", which must be handled appropriately in the calling code. Resolves iovisor#1212. New unit tests for codegen and bpftrace are added.
e5cee42
to
16b2b78
Compare
Thanks, they all passed now.
Sounds good, ok, fixed. I'll keep this in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire codepath is pretty gnarly and is in great need of a good refactor. This PR doesn't make it materially worse (in fact it might even be a little better).
LGTM but every time anyone touches this code path I get scared something's gonna break but have no real way of knowing.
It is now possible to run e.g. this:
Resolves #1212.
Checklist
docs/reference_guide.md
CHANGELOG.md