Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create int type Identifier when it is used in sizeof() #1622

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

mmisono
Copy link
Collaborator

@mmisono mmisono commented Nov 15, 2020

Currently, int8, in16, ... etc are considered as a identifier when used other than sizeof. This disabled it , and fixed the following error:

sudo ./src/bpftrace -e 'BEGIN { print(int32); }'
FATAL: unknown identifier "int32"
zsh: abort sudo ./src/bpftrace -e 'BEGIN { print(int32); }'
Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

@mmisono mmisono added the do-not-merge Changes are not ready to be merged into master yet label Nov 15, 2020
This fixed the following error:

```
sudo ./src/bpftrace -e 'BEGIN { print(int32); }'
FATAL: unknown identifier "int32"
zsh: abort sudo ./src/bpftrace -e 'BEGIN { print(int32); }'
```
@mmisono mmisono removed the do-not-merge Changes are not ready to be merged into master yet label Nov 20, 2020
@mmisono mmisono merged commit 03a9ed8 into bpftrace:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants