Fix compound assignments with non-unary expr #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenticularis39
force-pushed
the
fix-compound-op-parsing
branch
from
02b8b18
to
df786a8
Compare
lenticularis39
changed the title
Fix parser to accept any expression as the right side of a compound assignment, not only an unary expression. Fixes bpftrace#2291
lenticularis39
force-pushed
the
fix-compound-op-parsing
branch
from
df786a8
to
eeee26f
Compare
viktormalik
approved these changes
Jul 11, 2022
|
woops, thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parser to accept any expression as the right side of a compound
operation, not only an unary expression.
Fixes #2291
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md