Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable watchpoint support for PowerPC #2577

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Enable watchpoint support for PowerPC #2577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ and this project adheres to
- [#2479](https://github.com/iovisor/bpftrace/pull/2479)
- Add trailer to truncated strings
- [#2559](https://github.com/iovisor/bpftrace/pull/2559)
- Enable watchpoint support for PowerPC
- [#2577](https://github.com/iovisor/bpftrace/pull/2577)
#### Changed
- Improve attaching to uprobes with size 0
- [#2562](https://github.com/iovisor/bpftrace/pull/2562)
Expand Down
9 changes: 7 additions & 2 deletions src/arch/ppc64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,13 @@ std::string name()

std::vector<std::string> invalid_watchpoint_modes()
{
throw std::runtime_error(
"Watchpoints are not supported on this architecture");
// See PowerISA Book III v3.1B, Section 5.4.4 and 10.4
return std::vector<std::string>{
"x",
"rx",
"wx",
"rwx",
};
}

} // namespace arch
Expand Down
Loading