Fix alignment of byte arrays inside tuples #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
force-pushed
the
bytearray-align
branch
from
9b948e0
to
3c0c871
Compare
3 tasks
danobi
approved these changes
May 26, 2023
When using types internally represented by byte arrays inside tuples (e.g. usym, inet, etc.), LLVM aligns them to 1 byte inside the tuple. We must do the same in our internal type system so that the size of our type matches the size of the type generated by LLVM. This also renames the `SizedType::GetAlignment` method to `SizedType::GetInTupleAlignment` as it's only used to get alignment of a type when it is used inside a tuple and the old name was confusing. Added runtime and codegen tests for a case where bpftrace previously crashed.
viktormalik
force-pushed
the
bytearray-align
branch
from
3c0c871
to
c509ad0
Compare
ajor
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using types internally represented by byte arrays inside tuples (e.g. usym, inet, etc.), LLVM aligns them to 1 byte inside the tuple. We must do the same in our internal type system so that the size of our type matches the size of the type generated by LLVM.
This also renames the
SizedType::GetAlignmentmethod toSizedType::GetInTupleAlignmentas it's only used to get alignment of a type when it is used inside a tuple and the old name was confusing.Added runtime and codegen tests for a case where bpftrace previously crashed.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md