apparser: Improve error messages when APs are missing commas #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the following script (that's missing a comma):
```
kfunc:xfrm4_esp_rcv
kfunc:xfrm4_rcv
{
exit()
}
```
you get this error:
```
Attaching 1 probe...
ERROR: No BTF found for xfrm4_rcv
```
which is too vague.
This is b/c the parser effectively ignores spaces and combines the two
attachpoints into one string (sans space) when creating the
input to AttachPointParser. This is an unfortunate result of the
attachpoint parser design.
It's a bit too unwieldy to teach the parser about spaces (cuz we'd have
to sprinkle it everywhere), so opt to do the next best thing and have a
slightly more informative error instead.
With this commit, the error is now:
```
Attaching 1 probe...
ERROR: No BTF found for xfrm4_esp_rcvkfunc:xfrm4_rcv
```
which should provide a better hint to the user.
Given the following script (that's missing a comma):
```
t:syscalls:sys_enter_openat
t:syscalls:sys_exit_openat
{
exit();
}
```
you get this error:
```
repro.bt:1-2: ERROR: tracepoint probe type requires 2 arguments
```
This is too ambiguous.
The underlying reason is b/c the parser effectively ignores spaces and
combines the two attachpoints into one string (sans space) when creating
the input to AttachPointParser. This is an unfortunate result of the
attachpoint parser design.
It's a bit too unwieldy to teach the parser about spaces (cuz we'd have
to sprinkle it everywhere), so opt to do the next best thing and have a
slightly more informative error instead.
With this commit, the error is now:
```
repro.bt:1-2: ERROR: tracepoint probe type requires 2 arguments, found 4
```
which should provide a better hint to the user.
viktormalik
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for more details.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md