Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print: Print single map values #3027

Merged
merged 1 commit into from
Mar 1, 2024
Merged

print: Print single map values #3027

merged 1 commit into from
Mar 1, 2024

Conversation

arthurshau
Copy link
Contributor

@arthurshau arthurshau commented Mar 1, 2024 •
edited

Allows indexing a map with key(s) to print single map values while using the print() function.

Resolves #2779.

Checklist
  • Language changes are updated in man/adoc/bpftrace.adoc
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

@arthurshau arthurshau force-pushed the printsingle branch 4 times, most recently from 2d5abfb to 9f695ea Compare March 1, 2024 05:55
viktormalik
viktormalik reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@viktormalik viktormalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just one comment about an error message.

src/ast/passes/semantic_analyser.cpp Outdated Show resolved Hide resolved
@arthurshau
Copy link
Contributor Author

Addressed comments

@arthurshau
print: Print single map values
3c8825b 
Allows indexing a map with key(s) to print single map values while
using the print() function.
viktormalik
viktormalik approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@viktormalik viktormalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ajor
ajor approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@ajor ajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ajor ajor mentioned this pull request Mar 1, 2024
Open
@viktormalik viktormalik merged commit 7c98c79 into bpftrace:master Mar 1, 2024
19 checks passed
@arthurshau arthurshau deleted the printsingle branch March 1, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajor ajor ajor approved these changes

@viktormalik viktormalik viktormalik approved these changes

@danobi danobi Awaiting requested review from danobi danobi is a code owner

@fbs fbs Awaiting requested review from fbs fbs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print() single map values
3 participants
@arthurshau @ajor @viktormalik