Semantic Analyser Tests: Partial conversion to test_error() #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajor
commented
Mar 15, 2024
| test("iter:task,iter:task_file { 1 }", 1); | ||
| test("iter:task,iter:task_vma { 1 }", 1); | ||
| test("iter:task,f:func_1 { 1 }", 1); | ||
| test("iter:task { 1 }"); |
There was a problem hiding this comment.
A few of these test cases were just checking the exact same thing for each attachment point, so weren't giving us any extra test coverage. Deleted them to make my life easier
ajor
force-pushed
the
sema-tests-cleanup2
branch
from
c999c3e
to
c471197
Compare
Also delete some redundant test cases, which checked the same conditions for different iterator probes.
ajor
force-pushed
the
sema-tests-cleanup2
branch
from
c471197
to
e2fcc9b
Compare
danobi
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the first few and the last few tests in semantic_analyser.cpp over to checking error messages on failure.