Add user-friendly error for multiple for loops #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not updating the changelog as for loops are not released, yet. |
|
Semantic analyser unit test? It'd help make more clear what we are preventing. |
viktormalik
force-pushed
the
multiple-for-error
branch
from
8e11711
to
ebb966d
Compare
Yeah, I was reluctant to add it as this is a "missing feature" but with the test, we'll also get notified when we fix the issue. Added. |
jordalgo
approved these changes
Jun 12, 2024
Currently, we do not allow for-loops to be used from multiple probes at the same time (see [1] for details). If that happens, detect it in the semantic analyser and print a nice error instead of a generic "Error loading program". [1] bpftrace#3021
viktormalik
force-pushed
the
multiple-for-error
branch
from
ebb966d
to
681f6e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not allow for-loops to be used from multiple probes at the same time (see #3021 for details). If that happens, detect it in the semantic analyser and print a nice error instead of a generic
Error loading program.Checklist
man/adoc/bpftrace.adocCHANGELOG.md