Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve startup speed for expanded probes w/o * #559

Merged

Conversation

mmarchini
Copy link
Contributor

@mmarchini mmarchini commented Apr 18, 2019

Improved speed by not performing wildcard match on probes without a
wildcard. Speedup of complex scripts (especially those using tracepoints
with arguments) will be much faster now. As an example from our toos:

Before:

# time bpftrace -d statsnoop.bt
...
bpftrace -d statsnoop.bt  1.67s user 0.06s system 99% cpu 1.748 total

After:

# time bpftrace -d statsnoop.bt
...
bpftrace -d statsnoop.bt  0.06s user 0.02s system 80% cpu 0.098 total

Ref: #526

Improved speed by not performing wildcard match on probes without a
wildcard. Speedup of complex scripts (especially those using tracepoints
with arguments) will be much faster now. As an example from our toos:

Before:

  # time bpftrace -d statsnoop.bt
  ...
  bpftrace -d statsnoop.bt  1.67s user 0.06s system 99% cpu 1.748 total

After:

  # time bpftrace -d statsnoop.bt
  ...
  bpftrace -d statsnoop.bt  0.06s user 0.02s system 80% cpu 0.098 total

Ref: bpftrace#526
@brendangregg
Copy link
Contributor

Makes sense, thanks!

@brendangregg brendangregg merged commit 8816fa4 into bpftrace:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants