Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use []byte for event body #37

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Use []byte for event body #37

merged 1 commit into from
Apr 20, 2018

Conversation

bpineau
Copy link
Owner

@bpineau bpineau commented Apr 20, 2018

Using []byte rather than string is cleaner:

  • That's what we get from yaml.Marshal, and what Write() to file will do
  • Easier to make things io.Reader / io.Writer interface compliant

@bpineau
Use []byte for event body
26cc1f4 
Using []byte rather than string is cleaner:
* That's what we get from yaml.Marshal, and what Write() to file will do
* Easier to make things io.Reader / io.Writer interface compliant
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 91.909% when pulling 26cc1f4 on byte_events into af7823b on master.

@bpineau bpineau merged commit b59030b into master Apr 20, 2018
@bpineau bpineau deleted the byte_events branch April 20, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpineau @coveralls