Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a temp file + rename for atomic changes #38

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Use a temp file + rename for atomic changes #38

merged 1 commit into from
Apr 20, 2018

Commits on Apr 20, 2018

  1. Use a temp file + rename for atomic changes 

    We were updating the files in place. This left a small time frame
where files may be commited while in the middle of a write. The
final, complete file would then be commited soon after, but we
would end up with an ugly, partial commit in the history.

Using a temporary file then a rename ensure git only see complete
files (rename is atomic on POSIX filesystems).
    @bpineau
    bpineau committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    5f6a8a9 View commit details
    Browse the repository at this point in the history