Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race in recorder Start()/Stop() #42

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Fix a race in recorder Start()/Stop() #42

merged 1 commit into from
Apr 23, 2018

Conversation

bpineau
Copy link
Owner

@bpineau bpineau commented Apr 23, 2018

If a recorder is Stop()ed before he finished Start()ing,
he may not have created the channels used by Stop().
Those should be initialized at instanciation time, really.

@bpineau
Fix a race in recorder Start()/Stop()
29d69be 
If a recorder is Stop()ed before he finished Start()ing,
he may not have created the channels used by Stop().
Those should be initialized at instanciation time, really.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.195% when pulling 29d69be on recorder_race into 9a64ab0 on master.

@bpineau bpineau merged commit 729fc03 into master Apr 23, 2018
@bpineau bpineau deleted the recorder_race branch April 23, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpineau @coveralls