Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move target folder creation at startup time #52

Merged
merged 1 commit into from
Apr 29, 2018

Conversation

bpineau
Copy link
Owner

@bpineau bpineau commented Apr 29, 2018

Where it belongs, so we can fail early and cleanly.
Also, doing that while on a separate goroutine was
pretty bad (since we'd have to either ignore the
error, or panic in a package).

Where it belongs, so we can fail early and cleanly.
Also, doing that while on a separate goroutine was
pretty bad (since we'd have to either ignore the
error, or panic in a package).
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.071% when pulling 31dd524 on move_folder_creation_at_startup_time into 74881fb on master.

@bpineau bpineau merged commit 6056e62 into master Apr 29, 2018
@bpineau bpineau deleted the move_folder_creation_at_startup_time branch April 29, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants