Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using both remote repos and a persistent clone #87

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

bpineau
Copy link
Owner

@bpineau bpineau commented Jul 21, 2019

Should close #86 (thanks @tchellomello)

@coveralls
Copy link

coveralls commented Jul 21, 2019

Coverage Status

Coverage decreased (-0.6%) to 85.594% when pulling 5596a90 on start-with-existing-repos into 929386f on master.

@tchellomello
Copy link

@bpineau
I've updated my deployment with the new image as below:

kubectl set image deploy/katafygio-git katafygio=bpineau/katafygio:v0.8.0-remoteandlocalpersist --record
deployment.extensions/katafygio-git image updated

The new pod loaded as expected:

Containers:
  katafygio:
    Container ID:  containerd://790e6da81087fa9c81ca9bde79b100a7602b18a9ca1e9bb0e23ea4e8c3c927d9
    Image:         bpineau/katafygio:v0.8.0-remoteandlocalpersist
    Image ID:      docker.io/bpineau/katafygio@sha256:8c406df8089c5b078b9b19f121ae603eb2cd2a5ba6618eea7a7ca51af8bcb2d6
    Port:          8080/TCP
    Host Port:     0/TCP
    Command:
      /usr/bin/katafygio
      --local-dir=/var/lib/katafygio/data
      --healthcheck-port=8080
      --git-url=http://katafygio:<REDACTED>@gitea-http-service.default.svc.cluster.local/mmello/katafygio-backups.git
      --log-level=info
      --log-output=stdout
      --resync-interval=300
      --exclude-kind=replicaset
      --exclude-kind=endpoints
      --exclude-kind=event
    State:          Running
      Started:      Sun, 21 Jul 2019 22:12:03 -0400
    Ready:          True
    Restart Count:  0

To re-test t, I've forced a kill and started it again

kubectl delete pod katafygio-git-bdcfbb7f-wjstf
pod "katafygio-git-bdcfbb7f-wjstf" deleted

And voilla!! It worked like a charm!!! 👍

kubectl logs katafygio-git-bdcfbb7f-jqfh6
time="2019-07-22 02:16:25" level=info msg="katafygio starting"
time="2019-07-22 02:16:25" level=info msg="Starting http healtcheck handler"
time="2019-07-22 02:16:25" level=info msg="Starting git repository synchronizer"
time="2019-07-22 02:16:25" level=info msg="Starting event recorder"
time="2019-07-22 02:16:25" level=info msg="Starting all kubernetes controllers"

Local and remote git updated as expected. All working as expected!! Good job @bpineau !!!! Thanks for the quick fix!! 🥇

@bpineau bpineau merged commit fac34fb into master Jul 28, 2019
@bpineau bpineau deleted the start-with-existing-repos branch July 28, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/var/lib/katafygio/data: git clone failed with code exit status 128: fatal: destination path
3 participants