Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 #140

Merged
merged 33 commits into from Mar 23, 2022
Merged

V1 #140

merged 33 commits into from Mar 23, 2022

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Mar 18, 2022 •
edited

Lets get to version 1.0 🚀

  • bpkg.json migration with package.json backwards compat
  • shellcheck and lint clean up
  • Actions CI

@jwerle jwerle requested a review from Potherca March 18, 2022 17:13
@jwerle jwerle self-assigned this Mar 18, 2022
Potherca and others added 22 commits March 18, 2022 13:14
@Potherca @jwerle
Add support for bpkg.json, next to package.json.
c85ab3b
@Potherca @jwerle
Fix all Shellcheck SC1090 violations.
62c9c31
@Potherca @jwerle
Fix all Shellcheck SC2004 violations.
a623d00
@Potherca @jwerle
Fix all Shellcheck SC2053 violations.
a1c9758
@Potherca @jwerle
Fix all Shellcheck SC2059 violations.
4c6eb87
@Potherca @jwerle
Fix all Shellcheck SC2086 violations.
9b7cb21
@Potherca @jwerle
Fix all Shellcheck SC2236 violations.
fb50ebe
@Potherca @jwerle
Fix all Shellcheck SC2219 violations.
bc0fa54
@Potherca @jwerle
Fix all Shellcheck SC2230 violations.
2a30a04
@Potherca @jwerle
Fix all Shellcheck SC2155 violations.
1305200
@Potherca @jwerle
Fix all Shellcheck SC2034 violations.
f94e3a0
@Potherca @jwerle
Remove unused variable.
3013e91
@Potherca @jwerle
Fix all Shellcheck SC2206 violations.
a9936a2
@Potherca @jwerle
Fix various Shellcheck violations.
d7b0262
@Potherca @jwerle
Fix more Shellcheck SC2155 violations.
aaa2989
@Potherca @jwerle
Fix more Shellcheck SC2034 violations.
ccde826
@Potherca @jwerle
Fix more Shellcheck violations.
4f7bbc3
@Potherca @jwerle
Add GitHub Action for Shellcheck.
579eb2f
@Potherca @jwerle
Update pipeline-components/shellcheck in workflow.
17b7573
@Potherca @jwerle
Change pipeline-components/shellcheck to latest version.
067384e
@jwerle
refactor(): support 'bpkg.json'
1034144
@jwerle
refactor(): support custom 'deps/' dir
eb2fe6d
@francescobianco
Copy link
Member

francescobianco commented Mar 19, 2022 •
edited

RESPECT

Hi @jwerle @Potherca a lot of amazing work is done! This feel me good! Thanks!

@jwerle
Copy link
Member Author

jwerle commented Mar 21, 2022

@Potherca @francescobianco we have all checks passing now!

@jwerle jwerle mentioned this pull request Mar 21, 2022
Open
6 tasks
@Potherca
Copy link
Member

I'll review this week.

Potherca
Potherca approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one typo and 2 questions, I didn't see anything weird.

.shellcheckrc Show resolved Hide resolved
lib/json/all-tests.sh Outdated Show resolved Hide resolved
lib/run/run.sh Outdated Show resolved Hide resolved
@jwerle jwerle merged commit 26f2da8 into master Mar 23, 2022
@jwerle jwerle deleted the v1 branch March 23, 2022 18:17
@jwerle jwerle removed their assignment Mar 23, 2022
This was referenced Mar 27, 2022
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Potherca Potherca Potherca approved these changes

@francescobianco francescobianco Awaiting requested review from francescobianco

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwerle @francescobianco @Potherca