chore(): initial 'versions.yml' #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
added
the
setup-scipt
jwerle
force-pushed
the
generate-versions-test-workflow-ci
branch
from
b66d9d3
to
7ce000e
Compare
Potherca
requested changes
Jun 13, 2022
.github/workflows/versions.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Verify Setup For Tags | ||
| run: | |
There was a problem hiding this comment.
Instead of having an individual entry for each version, I would suggest using a job matrix
.github/workflows/versions.yml
Outdated
| run: | | ||
| echo "Verify 0.0.2:" | ||
| curl https://raw.githubusercontent.com/bpkg/bpkg/0.0.2/setup.sh | bash | ||
| bpkg --version | grep 0.0.2 >/dev/null || { |
There was a problem hiding this comment.
Something is nagging at me that this line has issues but I can't seem to get the problem in clear focus.
It might come to me later...
| @@ -0,0 +1,32 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
If a GitHub Actions matrix is used, this script will no longer be needed.
There was a problem hiding this comment.
do you know how we can get all tags into the matrix?
|
going to get this into a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.