Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(README): add preliminary structure #2

Merged
merged 8 commits into from
Dec 21, 2018
Merged

feat(README): add preliminary structure #2

merged 8 commits into from
Dec 21, 2018

Conversation

nikku
Copy link
Member

@nikku nikku commented Dec 20, 2018 •
edited
Loading

Closes #1

@ghost ghost assigned nikku Dec 20, 2018
@ghost ghost added the needs review label Dec 20, 2018
@nikku nikku requested a review from barmac December 20, 2018 22:51
@ghost ghost assigned barmac Dec 21, 2018
@barmac
Copy link
Member

barmac commented Dec 21, 2018

Fixed merge conflict.

barmac
barmac approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merge-me merge-me bot merged commit 46fe6f0 into master Dec 21, 2018
@ghost ghost removed the needs review label Dec 21, 2018
@delete-merged-branch delete-merged-branch bot deleted the nikku-patch-1 branch December 21, 2018 07:33
This was referenced Dec 21, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees

@nikku nikku

@barmac barmac

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikku @barmac