Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better boundary event handling #38

Merged
merged 9 commits into from Jun 9, 2023
Merged

Better boundary event handling #38

merged 9 commits into from Jun 9, 2023

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented Jun 9, 2023

image

This PR refactors the library to make it easier to add new functionality. The following things have changed for boundary events:

  • new elements are inserted to the bottom-right of the element
  • boundary events are distributed along the width of the host, but only on the bottom
  • we ensure the path always exits on the bottom
  • increased the height of each cell because boundary events were sticking out (oops)

Minor unrelated fixed in this PR:

  • add styles to the test page 364813b
  • exclusive gateways did not show the marker 6bf6470

@marstamm marstamm self-assigned this Jun 9, 2023
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 9, 2023
nikku
nikku approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I like the test coverage, too! 🙈

@fake-join fake-join bot merged commit 1cd24c4 into master Jun 9, 2023
4 checks passed
@fake-join fake-join bot deleted the better-attacher-handling branch June 9, 2023 17:48
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 9, 2023
philippfromme
philippfromme reviewed Jun 12, 2023
View reviewed changes
Copy link

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 bug-free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme left review comments

@nikku nikku nikku approved these changes

Assignees

@marstamm marstamm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marstamm @nikku @philippfromme