Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the .cjs extension for CommonJS export #40

Merged
merged 1 commit into from Jul 11, 2023
Merged

Use the .cjs extension for CommonJS export #40

merged 1 commit into from Jul 11, 2023

Conversation

mortenab
Copy link
Contributor

This PR makes it so that CommonJS exports use the .cjs extension, allowing the module to be imported into a Node app using CommonJS.

I've verified that after running npm run build, the dist folder contains an index.cjs and an index.cjs.map file.

Closes #39

@mortenab mortenab mentioned this pull request Jul 11, 2023
Closed
@nikku nikku merged commit a9894c4 into bpmn-io:master Jul 11, 2023
2 checks passed
@nikku
Copy link
Member

nikku commented Jul 11, 2023

Released this fix with v0.4.0. Thanks 🏅

@mortenab
Copy link
Contributor Author

@nikku thank you for the quick turnaround. Works great for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommonJS exports should use the .cjs extension
2 participants
@mortenab @nikku