fix: added explicit encoding #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marstamm
approved these changes
Jul 27, 2023
|
Published as 0.12.1 |
|
The best way to ensure that this properly loads is to not serve files using some bogus encoding, but UTF8 (which is standard, on the web). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrive the bug
I used
bpmn-js/dist/assets/bpmn-font/css/bpmn-embedded.cssfor my palette panel bpmn, but sometimes i got this, it seems it may be reproduce only in google chrome browser, i tried to experement with my css file connection but it still doesn’t workAssets
Solution
I added explicit encoding into root css of bpmn font style and everything work well
resources:https://stackoverflow.com/questions/57910667/chrome-not-displaying-webfont-falling-back-to-times-new-roman-when-font-face-delink the issue:https://forum.bpmn.io/t/broken-icon-coding/9564