-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incosistent behavior of boolean property conditions #84
Comments
I can reproduce this bug. Root cause is this line, where we check if the condition has an bpmn-js-element-templates/src/cloud-element-templates/Condition.js Lines 57 to 59 in 8ccc64e
The Code only checks if |
When implementing, I noticed that initially, the value will be
I'll go ahead with the identified fix and open a follow-up issue to decide if we always want to persist "false" by default |
Released |
fix: correctly handle failsy properties in element template conditions Related to bpmn-io/bpmn-js-element-templates#84
fix: correctly handle failsy properties in element template conditions Related to bpmn-io/bpmn-js-element-templates#84
Describe the Bug
Boolean properties behave inconsistently when it comes to referencing them in conditions:
true
, it works as expectedfalse
, nothing happensfalse
(checkbox not active), however, the default element template value is""
(empty string).Steps to Reproduce
Element template
inputForActiveCheckbox
is added when the checkbox is active, however when it's not active,inputForInactiveCheckbox
is not added.Expected Behavior
false
should work as expectedfalse
unless specified otherwise to be consistent with the UI representationEnvironment
The text was updated successfully, but these errors were encountered: