Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labels are visible now #6

Merged
merged 1 commit into from Nov 28, 2023
Merged

labels are visible now #6

merged 1 commit into from Nov 28, 2023

Conversation

Jean-Christophe-S
Copy link
Contributor

@Jean-Christophe-S Jean-Christophe-S commented Nov 21, 2023 •
edited

This change resolves the issue I stated in the forum. Labels were not visible anymore and changing them lead to crashes.

Signed-off-by: Jean-Christophe Schmitt jean-christophe.schmitt@rwth-aachen.de

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@barmac
Copy link
Member

barmac commented Nov 28, 2023

Hi, we cannot merge your contribution until you sign the CLA :)

@Jean-Christophe-S
Copy link
Contributor Author

done :)

nikku
nikku approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. 🎉

@nikku nikku merged commit 2d9dd7b into bpmn-io:main Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jean-Christophe-S @CLAassistant @barmac @nikku