Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task headers get lost when switching to User Task #738

Closed
pihme opened this issue Jun 27, 2022 · 3 comments · Fixed by #740
Closed

Task headers get lost when switching to User Task #738

pihme opened this issue Jun 27, 2022 · 3 comments · Fixed by #740
Assignees
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@pihme
Copy link

pihme commented Jun 27, 2022

Describe the Bug
If you add task headers to a Service Task/Send Task/Script Task and change the element to a User Task, the task headers are gone. This is inconsistent in comparison to e.g. changing a Service Task to a Send Task where the headers are kept

Steps to Reproduce

  1. Create a Camnuda 8 BPMN diagram
  2. Create a Service Task
  3. Add headers to the service task
  4. Use wrench menu to change Service Task to a Send Task
  5. Notice that the task headers are copied over from the Service Task
  6. Use wrench menu to change Send Task to a User Task
  7. Notice that the headers were removed

Note that this only happens in this direction. If you add headers to a user task and then change it to a service task, then the headers are kept

Expected Behavior

Headers are kept

Environment

  • Browser: Firefox
  • OS: Ubuntu 21.04
  • Library version: Desktop Modeler 5.0.0, current web modeler
@pihme pihme added the bug Something isn't working label Jun 27, 2022
@smbea
Copy link
Contributor

smbea commented Jun 28, 2022

I can confirm that the task headers are not maintained for user task. Moving to backlog

@smbea smbea added backlog Queued in backlog spring cleaning Could be cleaned up one day ready Ready to be worked on and removed backlog Queued in backlog labels Jun 28, 2022
@smbea
Copy link
Contributor

smbea commented Jul 15, 2022

I couldn't figure out where this issue originates. Since it's not a priority, I will drop it for now and move it to back log.

@smbea smbea added backlog Queued in backlog and removed ready Ready to be worked on labels Jul 15, 2022
@smbea smbea removed their assignment Jul 15, 2022
@pinussilvestrus
Copy link
Contributor

We missed adding bpmn:UserTask as allowed parent for the headers in the moddle descriptors.

I will add the missing piece.

@pinussilvestrus pinussilvestrus self-assigned this Aug 15, 2022
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed backlog Queued in backlog labels Aug 15, 2022
@pinussilvestrus pinussilvestrus transferred this issue from bpmn-io/bpmn-js Aug 16, 2022
pinussilvestrus pushed a commit to camunda/zeebe-bpmn-moddle that referenced this issue Aug 16, 2022
@pinussilvestrus pinussilvestrus added the needs review Review pending label Aug 16, 2022 — with bpmn-io-tasks
nikku pushed a commit to camunda/zeebe-bpmn-moddle that referenced this issue Aug 17, 2022
@nikku nikku added fixed upstream Requires integration of upstream change and removed in progress Currently worked on needs review Review pending labels Aug 17, 2022
pinussilvestrus pushed a commit that referenced this issue Aug 18, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Aug 18, 2022
pinussilvestrus pushed a commit to camunda/camunda-bpmn-js that referenced this issue Aug 18, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 18, 2022
@fake-join fake-join bot closed this as completed in #740 Aug 18, 2022
fake-join bot pushed a commit that referenced this issue Aug 18, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 18, 2022
merge-me bot pushed a commit to camunda/camunda-bpmn-js that referenced this issue Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Development

Successfully merging a pull request may close this issue.

4 participants