Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse preact instance and adjust to new exports #525

Merged
merged 7 commits into from
Dec 15, 2021

Conversation

barmac
Copy link
Member

@barmac barmac commented Dec 10, 2021

This PR:

  • adds missing package.json#files field to include only the build artifacts
  • removes unnecessary index.js file in the root
  • transforms the package to re-use preact shipped with @bpmn-io/properties-panel
  • adjusts @bpmn-io/properties-panel imports to the new structure introduced in the PR linked below.

Requires bpmn-io/properties-panel#124 to be merged and released

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 10, 2021
@barmac barmac changed the title Re export building blocks Reuse preact instance and adjust to new exports Dec 10, 2021
@barmac barmac force-pushed the re-export-building-blocks branch 2 times, most recently from b246a55 to e9b7cb6 Compare December 15, 2021 10:23
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fundamental improvement. 👍

@barmac barmac marked this pull request as ready for review December 15, 2021 14:42
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 15, 2021
@barmac barmac merged commit 319aaf9 into next Dec 15, 2021
@barmac barmac deleted the re-export-building-blocks branch December 15, 2021 14:42
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants