Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules allow for Message Flow to be drawn when dragging an element outside of canvas #1033

Closed
barmac opened this issue May 17, 2019 · 1 comment · Fixed by #1036
Closed

Rules allow for Message Flow to be drawn when dragging an element outside of canvas #1033

barmac opened this issue May 17, 2019 · 1 comment · Fixed by #1036
Assignees
@nikku
Labels
bug Something isn't working

Comments

@barmac
Copy link
Member

barmac commented May 17, 2019 •
edited

Describe the Bug

Interesting behavior when you leave the canvas while previewing connection:

16-05-_2019_15-47-58

Originally posted by @philippfromme in #1028 (comment)

Noticable within #1028. Bug already exists in the library, though.

This is caused by BpmnRules. canConnectMessageFlow returns true when shape is outside of the diagram as it can't find its organizational parent. Thus, organizational parents of the elements are different (undefined vs. process/participant) and rules return message flow as an appropriate connection.

Steps to Reproduce

Drag a shape outside of canvas like on the screencast above.

Expected Behavior

No connection allowed.

Environment
@barmac barmac added the bug Something isn't working label May 17, 2019
nikku added a commit that referenced this issue May 17, 2019
@nikku
fix(rules): do not allow message flows to outside diagram shapes
4551118 
Closes #1033
@nikku nikku self-assigned this May 17, 2019
@nikku nikku added the in progress Currently worked on label May 17, 2019
@nikku nikku mentioned this issue May 17, 2019
Merged
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels May 17, 2019
nikku added a commit that referenced this issue May 17, 2019
@nikku
fix(rules): do not allow message flows to outside diagram shapes
a7defa2 
Closes #1033
merge-me bot pushed a commit that referenced this issue May 17, 2019
@nikku @merge-me
fix(rules): do not allow message flows to outside diagram shapes
576a3de 
Closes #1033
@barmac
Copy link
Member Author

barmac commented May 17, 2019

Fixed via #1036

@barmac barmac closed this as completed May 17, 2019
@barmac barmac removed the needs review Review pending label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rules): do not allow message flows to outside diagram shapes bpmn-io/bpmn-js
2 participants
@nikku @barmac