Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups in empty diagram cause errors #1133

Closed
BelindaBecker opened this issue Jul 25, 2019 · 7 comments
Closed

Groups in empty diagram cause errors #1133

BelindaBecker opened this issue Jul 25, 2019 · 7 comments
Assignees
Labels
bug Something isn't working modeling
Milestone

Comments

@BelindaBecker
Copy link

Describe the Bug

After adding a group to an empty diagram, the editor crashes when trying to add other elements.

Steps to Reproduce

Steps to reproduce the behavior:

on https://demo.bpmn.io/new

  1. Open the empty/initial diagram
  2. delete the start event
  3. add a group
  4. add for example a pool

Result: the console throws a lot of errors and the editor gets stuck.

bpmn_group_bug
groups_error

Expected Behavior

It should be possible to keep on modeling.

Environment

Please complete the following information:

  • Browser: Chrome 75.0.3770.142
  • OS: Windows 10
  • Library version: The one deployed on https://demo.bpmn.io/new, should be bpmn-js 4.0.3
@nikku
Copy link
Member

nikku commented Jul 25, 2019

Could you provide us with your logs, starting from the first error?

@nikku
Copy link
Member

nikku commented Jul 25, 2019

On my machine (Arch Linux, your Chrome version) I cannot reproduce the issue given the steps you procided:

capture 79d5GQ_optimized

@BelindaBecker
Copy link
Author

Sure! This is what I get from the brwoser console:
Topmost errors in trace:
error_1

Next Error:
error_2

After this, the exactly same three errors are thrown multiple times.
I am able to reproduce this every time I do the steps describe above..

@BelindaBecker
Copy link
Author

I did some more testing: the error occurs only if you add a pool !

@nikku
Copy link
Member

nikku commented Jul 25, 2019

Thanks for the additional clarification. I can reproduce it now. We will have a look. 👍

@nikku nikku added blocker This issue blocks further progress. bug Something isn't working modeling and removed blocker This issue blocks further progress. labels Jul 25, 2019
@nikku nikku added this to the M30 milestone Jul 25, 2019
@nikku nikku added the ready Ready to be worked on label Jul 26, 2019 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed ready Ready to be worked on labels Aug 2, 2019 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus self-assigned this Aug 2, 2019
@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed in progress Currently worked on labels Aug 2, 2019 — with bpmn-io-tasks
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Aug 2, 2019

Root-Cause: In CreateParticipantBehavior the childrenBBox has malformed (NaN) height and width properties, because bpmn:Group elements are ignored. If no other elements are there, of course, no children are still available to create the correct participant bounds.

I'll have a look at this next week 🎸

@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed ready Ready to be worked on labels Aug 5, 2019 — with bpmn-io-tasks
pinussilvestrus pushed a commit that referenced this issue Aug 5, 2019
* Ensure there are leftover children to calculate createConstraints

Closes #1133
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 5, 2019
merge-me bot pushed a commit that referenced this issue Aug 5, 2019
* Ensure there are leftover children to calculate createConstraints

Closes #1133
@pinussilvestrus
Copy link
Contributor

Closed via 5d5f33c

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 5, 2019
@nikku nikku modified the milestones: M30, M29.2 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modeling
Development

No branches or pull requests

3 participants