Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When I create child lane, I've not childLaneSet in xml export (in new version also in online demo) #1254

Closed
Varooneh opened this issue Dec 3, 2019 · 1 comment
Closed

When I create child lane, I've not childLaneSet in xml export (in new version also in online demo) #1254

Varooneh opened this issue Dec 3, 2019 · 1 comment
Assignees
@nikku
Labels
bug Something isn't working
Milestone
M33

Comments

@Varooneh
Copy link

Varooneh commented Dec 3, 2019

Describe the Bug
In bpmn-js version 3.* when I create child lane in a lane, exported XML has bpmn2:childLaneSet XML node and define child lanes in this node.
In new version (also online demo), when I create child lane, in exported XML I've not bpmn2:childLaneSet .

Steps to Reproduce
1- I create a bpmn diagram in old version (3.*)
old_version

And in exported XML I've like this:

<bpmn2:laneSet id="LaneSet_0dz1dwx">
      <bpmn2:lane id="Lane_1amw7ib">        
        <bpmn2:flowNodeRef>StartEvent_1</bpmn2:flowNodeRef>
  </bpmn2:lane>
  <bpmn2:lane id="Lane_0ccivr4">        
    <bpmn2:childLaneSet id="LaneSet_1pbfwpy">
      <bpmn2:lane id="Lane_0imicyw" />
      <bpmn2:lane id="Lane_01xan8i">            
        <bpmn2:childLaneSet id="LaneSet_0p041z7">
          <bpmn2:lane id="Lane_00syf83" />
          <bpmn2:lane id="Lane_1xnempi" />
        </bpmn2:childLaneSet>
      </bpmn2:lane>
    </bpmn2:childLaneSet>
  </bpmn2:lane>
</bpmn2:laneSet>

2- And again, I create above diagram in new version on online demo and when export as xml, I've this:

<bpmn:laneSet id="LaneSet_0nj9tm1">
  <bpmn:lane id="Lane_126mif5" />
  <bpmn:lane id="Lane_16t32x1" />
  <bpmn:lane id="Lane_0i7203j" />
  <bpmn:lane id="Lane_1rwva4y" />
</bpmn:laneSet>

Environment

  • Browser: [Chrome (latest version)]
  • OS: [Windows 10]
  • Library version: [3., 5,]
@Varooneh Varooneh added the bug Something isn't working label Dec 3, 2019
@nikku nikku self-assigned this Dec 9, 2019
@nikku nikku added the ready Ready to be worked on label Dec 9, 2019 — with bpmn-io-tasks
nikku added a commit that referenced this issue Dec 11, 2019
@nikku
fix(modeling): correct creation of nested lanes
cccdd64 
With diagram-js@5 we've introduced the CreateBehavior that ensures
elements are not created on top of lanes but always on top of the actual
participant.

Unfortunately we forgot about the fact that lanes are created once in a
while, too.

This commit accounts for this fact and ensures we do not adjust the
parent of to-be-created lanes.

(A test cases for splitting nested lanes did not exist until now).

Closes #1254
Closes #1253
@nikku nikku mentioned this issue Dec 11, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Dec 11, 2019
@nikku nikku added this to the M33 milestone Dec 11, 2019
@nikku nikku mentioned this issue Dec 11, 2019
Closed
fake-join bot pushed a commit that referenced this issue Dec 11, 2019
@nikku @fake-join
fix(modeling): correct creation of nested lanes
b4b5d1d 
With diagram-js@5 we've introduced the CreateBehavior that ensures
elements are not created on top of lanes but always on top of the actual
participant.

Unfortunately we forgot about the fact that lanes are created once in a
while, too.

This commit accounts for this fact and ensures we do not adjust the
parent of to-be-created lanes.

(A test cases for splitting nested lanes did not exist until now).

Closes #1254
Closes #1253
@nikku
Copy link
Member

nikku commented Dec 11, 2019

Closed via #1256.

@nikku nikku closed this as completed Dec 11, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Milestone
M33
Development

No branches or pull requests
2 participants
@nikku @Varooneh