Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving elements onto breadcrumb blow up editor #1511

Closed
nikku opened this issue Oct 21, 2021 · 6 comments · Fixed by #1553
Closed

Moving elements onto breadcrumb blow up editor #1511

nikku opened this issue Oct 21, 2021 · 6 comments · Fixed by #1553
Labels
bug Something isn't working

Comments

@nikku
Copy link
Member

nikku commented Oct 21, 2021

Describe the Bug

If I accidentally move an element over the newly introduced breadcrumbs the editor blows up:

capture kZ2UqD_optimized

Steps to Reproduce

  1. Drill down into collapsed process
  2. Move sub-process contents onto breadcrumb
  3. See editor blowing up (not recoverable)

Expected Behavior

Two options: Move is rejected or, even better, breadcrumbs are ignored during dragging (pointer-events: none).

Environment

  • Browser: any
  • OS: any
  • Library version: bpmn-js@next (develop)
@nikku nikku added the bug Something isn't working label Oct 21, 2021
@nikku
Copy link
Member Author

nikku commented Oct 21, 2021

@marstamm Are you already aware of this one? If not, let us add it to the list of our TODOs.

@marstamm

This comment has been minimized.

@nikku

This comment has been minimized.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed in progress Currently worked on labels Oct 21, 2021
@marstamm marstamm added ready Ready to be worked on and removed needs review Review pending labels Nov 4, 2021
@nikku
Copy link
Member Author

nikku commented Nov 23, 2021

With #1506 closed we should give this another look, shall we @marstamm.

@marstamm
Copy link
Contributor

I think this is a general problem with the viewer. You cannot move elements (on the breadcrumbs or otherwise). This

// do not resize plane elements:
// root elements, collapsed sub-processes
if (is(target.di, 'bpmndi:BPMNPlane')) {
return false;
}
is the fix we need and it will be integrated with #1536

@nikku
Copy link
Member Author

nikku commented Nov 24, 2021

Note that we've solved it for the palette already; we shall aim for a similar fix, UI wise:

capture G1p3qU_optimized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants