Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resizing for all text elements as for TextAnnotation #1513

Open
topialla opened this issue Oct 24, 2021 · 5 comments
Open

Add resizing for all text elements as for TextAnnotation #1513

topialla opened this issue Oct 24, 2021 · 5 comments
Labels
backlog Queued in backlog enhancement New feature or request good first issue Good for newcomers modeling pr welcome We rely on a community contribution to improve this.

Comments

@topialla
Copy link

Text elements in tasks or at gateways can have issues with proper spacing and readability.
So far I often edit the svg to properly align/size the text, but of course then I cannot reedit within this awesome tool ;-)

Describe the solution you'd like
For starters, it would be very helpful, if I could resize the textbox for gateways similar as can be done with TextAnnotations.
Longer term text sizing and markdownsupport for simple formatting would be great.

Describe alternatives you've considered
So far, I always use inkscape to edit the svg giving svg_A. Then, if needed, I change the bpmn in bpmn.io and export a new svg svg_B. Then I open svg_B, copy the changed parts, delete the changed parts from svg_A and use paste in place.
This is quite cumbersome.

grafik

@topialla topialla added the enhancement New feature or request label Oct 24, 2021
@barmac
Copy link
Member

barmac commented Oct 25, 2021

Thank you for creating this issue.

So if I get it correctly, you'd like to be able to take this:

image

and transform it into something like this:

image

and generally be able to resize free-floating labels.

I think this is a valid feature request. The BPMN standard allows for that so I don't see a reason why we shouldn't have it. Feel free to create a pull request and I can support you if you encounter any roadblocks.

@barmac barmac added backlog Queued in backlog good first issue Good for newcomers modeling pr welcome We rely on a community contribution to improve this. labels Oct 25, 2021
@topialla
Copy link
Author

topialla commented Nov 1, 2021

Yes, well summarized! Thank you.
I do not have time in the upcoming weeks, but will give it a try, or at least mention, when I start to try.

@smbea smbea self-assigned this Apr 25, 2022
@smbea smbea added in progress Currently worked on and removed backlog Queued in backlog labels Apr 25, 2022
@smbea
Copy link
Contributor

smbea commented May 10, 2022

I made some progress on this but wasn't able to finish it. I will move it back to backlog for now. Current progress is here: https://github.com/bpmn-io/bpmn-js/tree/1513-resize-external-labels

@smbea smbea removed their assignment May 10, 2022
@smbea smbea added backlog Queued in backlog and removed in progress Currently worked on labels May 10, 2022
@Ruandv
Copy link

Ruandv commented Jan 14, 2024

What else is still oustanding that I can assist with on this issue?
I have pulled the branch mentioned above and got it up and running. Everything seems to be working as explained

2024-01-14_22-30-02

@barmac
Copy link
Member

barmac commented Jan 15, 2024

I'd expect the label bounds to follow the text after resize. So if you make the label wider, the bounds should shrink vertically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request good first issue Good for newcomers modeling pr welcome We rely on a community contribution to improve this.
Development

No branches or pull requests

4 participants