Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize handles hidden behind elements #1520

Closed
1 task
nikku opened this issue Nov 4, 2021 · 2 comments
Closed
1 task

Resize handles hidden behind elements #1520

nikku opened this issue Nov 4, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@nikku
Copy link
Member

nikku commented Nov 4, 2021

Describe the Bug

On our develop branch the resize handles are hidden behind elements as well as the context pad, making it hard to impossible to resize in many common usage scenarios:

develop

capture BxYD9w_optimized

Released (v8.8.x, demo)

capture 09kI4y_optimized

Steps to Reproduce

  1. Run npm start on develop branch
  2. Try resizing sub-process center left or center right
  3. Observe behavior shown above

Expected Behavior

  • Resize handles are shown always on top (take pointer precedence over context pad and flow handles)

Environment

  • Browser: Chrome
  • OS: Any
  • Library version: bpmn-js@develop
@nikku nikku added the bug Something isn't working label Nov 4, 2021
@marstamm
Copy link
Contributor

marstamm commented Nov 4, 2021

Root Cause: the layer-resizers is rendered behind the Process layer:
image

Introduced with #1481

@nikku
Copy link
Member Author

nikku commented Nov 4, 2021

Thanks for investigating.

So we shall make sure our plane layers always sit before always on top layers.

@nikku nikku added the ready Ready to be worked on label Nov 4, 2021
marstamm added a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
marstamm added a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 4, 2021
@nikku nikku added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Nov 4, 2021 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Nov 5, 2021
@fake-join fake-join bot closed this as completed in #1524 Nov 5, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 5, 2021
@nikku nikku reopened this Nov 5, 2021
@nikku nikku added the ready Ready to be worked on label Nov 5, 2021 — with bpmn-io-tasks
marstamm added a commit to bpmn-io/diagram-js that referenced this issue Nov 8, 2021
marstamm added a commit to bpmn-io/diagram-js that referenced this issue Nov 8, 2021
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 8, 2021
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 8, 2021
nikku added a commit that referenced this issue Nov 8, 2021
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed ready Ready to be worked on in progress Currently worked on labels Nov 8, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants